Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Password Checklist UI and Fix "Remember Me" Functionality #412

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Improved Password Checklist UI and Fix "Remember Me" Functionality #412

merged 1 commit into from
Nov 7, 2024

Conversation

IkkiOcean
Copy link
Contributor

@IkkiOcean IkkiOcean commented Nov 7, 2024 •
edited
Loading

Description:

This PR addresses the following improvements and fixes:

  1. Password Requirements:

    • Added a checklist displaying password requirements.
    • The checklist is now left-aligned and free from bullet points using Tailwind CSS utilities.

  2. Fix "Remember Me":

    • Investigated and resolved the issue with the "Remember Me" checkbox, ensuring its state persists across page reloads.

Issue No.:

Close #397

Screenshots/Video (mandatory)

signup.mp4

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
  • I have gone through the contributing.md file before contributing.

Additional context (Mandatory):

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for bitbox-in ready!

Name Link
🔨 Latest commit e34739a
🔍 Latest deploy log https://app.netlify.com/sites/bitbox-in/deploys/672c7fb2b53fa10008f5b423
😎 Deploy Preview https://deploy-preview-412--bitbox-in.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@IkkiOcean
Copy link
Contributor Author

I found some problem with remember me button so I also fixed it in same PR :)

@Anuj3553 Anuj3553 self-requested a review November 7, 2024 15:19
@Anuj3553 Anuj3553 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Nov 7, 2024
@Anuj3553 Anuj3553 merged commit 8a00200 into Bitbox-Connect:main Nov 7, 2024
1 of 3 checks passed
@Anuj3553
Copy link
Collaborator

Anuj3553 commented Nov 7, 2024

Well done @IkkiOcean

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

🎉🎉 Thank you for your contribution! Your PR #412 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anuj3553 Anuj3553 Awaiting requested review from Anuj3553

Assignees

@IkkiOcean IkkiOcean

Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level2 Intermediate-level contribution or task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Password validation on sign up page
2 participants
@IkkiOcean @Anuj3553